RFR: 8318669: Target OS detection in 'test-prebuilt' makefile target is incorrect when running on MSYS2

Tue Oct 24 21:22:29 UTC 2023

On Tue, 24 Oct 2023 10:29:32 GMT, Frederic Thevenet <fthevenet at openjdk.org> wrote:

> This PR addresses OS detection not working properly when running test-prebuilt on MSYS2, which causes some Windows specific tests to misbehave or fail in Github Actions.

make/RunTestsPrebuilt.gmk line 162:

> 160:   OPENJDK_TARGET_OS_ENV := windows.cygwin
> 161: else
> 162:   ifeq ($(UNAME_OS), MINGW64)

Instead of nesting, this inside the else body, creating more nesting below, make supports 

else ifeq ...

By using that you can keep the else body with `unix` on the same indentation level.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16343#discussion_r1370823391