RFR: 8318669: Target OS detection in 'test-prebuilt' makefile target is incorrect when running on MSYS2 [v2]

Frederic Thevenet fthevenet at openjdk.org
Wed Oct 25 08:46:53 UTC 2023


On Tue, 24 Oct 2023 21:18:44 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Frederic Thevenet has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use 'else ifeq' statement
>
> make/RunTestsPrebuilt.gmk line 162:
> 
>> 160:   OPENJDK_TARGET_OS_ENV := windows.cygwin
>> 161: else
>> 162:   ifeq ($(UNAME_OS), MINGW64)
> 
> Instead of nesting, this inside the else body, creating more nesting below, make supports 
> 
> else ifeq ...
> 
> By using that you can keep the else body with `unix` on the same indentation level.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16343#discussion_r1371380767


More information about the build-dev mailing list