RFR: 8315786: [AIX] Build Disk Local Detection Issue with GNU-utils df on AIX

[Erik Joelsson]

On Wed, 6 Sep 2023 13:46:01 GMT, Deepa Kumari <duke at openjdk.org> wrote:

> Previously [JDK-8304364](https://github.com/openjdk/jdk/pull/13066/files) , the AIX build process raised complaints about the disk location detection, incorrectly determining that the build wasn't on a local disk. However, a partial fix introduced a new problem, the build process consistently reports that it's on a local disk, even when it's not
> The core problem here seems to be that Bash treats quoted commands as string literals, and it only evaluates them if you use 'eval' directly.
>  The  change ensure that Bash correctly evaluates the **DF** variable as a command.
> 
> Reported Issue : [JDK-8315786](https://bugs.openjdk.org/browse/JDK-8315786)

make/autoconf/basic.m4 line 482:

> 480:     # is the same. On older AIXes we just continue to live with a "not local build" warning.
> 481:     if test "x$OPENJDK_TARGET_OS" = xaix; then
> 482:       if ""$DF" -T local > /dev/null 2>&1"; then

Suggestion:

      if $DF -T local > /dev/null 2>&1; then

I can't test this, but I don't think the quotes serve any purpose here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15592#discussion_r1323319043