RFR: 8315786: [AIX] Build Disk Local Detection Issue with GNU-utils df on AIX [v2]
Deepa Kumari
duke at openjdk.org
Wed Sep 20 12:54:43 UTC 2023
On Tue, 12 Sep 2023 16:51:53 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Deepa Kumari has updated the pull request incrementally with one additional commit since the last revision:
>>
>> remove quotes
>
> make/autoconf/basic.m4 line 482:
>
>> 480: # is the same. On older AIXes we just continue to live with a "not local build" warning.
>> 481: if test "x$OPENJDK_TARGET_OS" = xaix; then
>> 482: if ""$DF" -T local > /dev/null 2>&1"; then
>
> Suggestion:
>
> if $DF -T local > /dev/null 2>&1; then
>
> I can't test this, but I don't think the quotes serve any purpose here.
@erikj79 Thanks for reviewing. I verified this test and it worked fine.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15592#discussion_r1331584402
More information about the build-dev
mailing list