RFR: 8312522: Implementation of Foreign Function & Memory API [v28]

Wed Sep 27 14:56:31 UTC 2023

On Wed, 27 Sep 2023 14:50:32 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix visibility issues
>>    
>>    Reviewed-by: mcimadamore
>>  - Review comments
>
> test/hotspot/jtreg/compiler/rangechecks/TestRangeCheckHoistingScaledIV.java line 32:
> 
>> 30:  * @modules jdk.incubator.vector
>> 31:  * @compile -source ${jdk.version} TestRangeCheckHoistingScaledIV.java
>> 32:  * @run main/othervm compiler.rangechecks.TestRangeCheckHoistingScaledIV
> 
> Not important but I assume the @compile line can be removed from a number of tests as it's no longer needed. It was needed for tests that didn't use @enablePreview.

Ok, I'll go over all the tests that I've changed and see if there are `@compile` tags that can be removed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15103#discussion_r1338741350