RFR: 8312522: Implementation of Foreign Function & Memory API [v28]

Jorn Vernee jvernee at openjdk.org
Wed Sep 27 16:50:34 UTC 2023


On Wed, 27 Sep 2023 14:52:52 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/rangechecks/TestRangeCheckHoistingScaledIV.java line 32:
>> 
>>> 30:  * @modules jdk.incubator.vector
>>> 31:  * @compile -source ${jdk.version} TestRangeCheckHoistingScaledIV.java
>>> 32:  * @run main/othervm compiler.rangechecks.TestRangeCheckHoistingScaledIV
>> 
>> Not important but I assume the @compile line can be removed from a number of tests as it's no longer needed. It was needed for tests that didn't use @enablePreview.
>
> Ok, I'll go over all the tests that I've changed and see if there are `@compile` tags that can be removed

Besides the `compiler/rangechecks/TestRangeCheckHoistingScaledIV` test I found one other test that uses `@compile` in this manner: `java/lang/Thread/jni/AttachCurrentThread/AttachTest`. I've amended both.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15103#discussion_r1338910373


More information about the build-dev mailing list