RFR: JDK-8329257: AIX: Switch HOTSPOT_TOOLCHAIN_TYPE from xlc to gcc

Joachim Kern jkern at openjdk.org
Tue Apr 2 11:26:02 UTC 2024


On Thu, 28 Mar 2024 17:33:29 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> src/hotspot/share/utilities/globalDefinitions_gcc.hpp line 83:
>> 
>>> 81:   #error "xlc version not supported, macro __open_xl_version__ not found"
>>> 82: #endif
>>> 83: #endif // AIX
>> 
>> This `#ifdef _AIX` might be obsolete, because configure will throw a warning if the compiler has a lower version, but it's only a warning.
>
> I'd prefer having less AIX specific parts in this file. Can this be moved somewhere else? Or maybe combine it with the AIX code above?

My question is, do we need this block, because now already configure warns about an outdated compiler, or is a warning to weak and we want to force this error here?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18536#discussion_r1547672502


More information about the build-dev mailing list