RFR: JDK-8329257: AIX: Switch HOTSPOT_TOOLCHAIN_TYPE from xlc to gcc [v3]
Kim Barrett
kbarrett at openjdk.org
Wed Apr 3 03:39:10 UTC 2024
On Wed, 3 Apr 2024 02:28:08 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> https://github.com/openjdk/jdk/pull/18586
>
> @kimbarrett I've been doing things to permit gcc/Windows, not clang. clang has too many different distributions on Windows for me to settle on one, and generalising all of them to be able to compile with any of the Windows clang distributions seamlessly and without issues sounds like a nightmare :P gcc on the other hand has just 2: MSYS2 MINGW64 with ucrt (Which is the one I'm working on) and standalone gcc Windows builds that link to ucrt
>
> I haven't sent a cleanup in this area because I thought my changes were too specific to gcc/Windows, and wouldn't help much with HotSpot in general. I've learnt from my mistakes in the past where I caused reviewers pain in reviewing my admittedly selfish changes to HotSpot :(
> That said, if it is requested of me, I can commit some cleanups to this file. What do you think?
@TheShermanTanker It depends on the details, of course. I think there are lots of possible cleanups in this
vicinity that have little or nothing to do with gcc/Windows specifically, though might help there too.
And yeah, I misremembered that it was not clang/Windows but rather gcc/Windows you were working on.
But the same points largely apply here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18536#discussion_r1548868243
More information about the build-dev
mailing list