RFR: JDK-8329257: AIX: Switch HOTSPOT_TOOLCHAIN_TYPE from xlc to gcc [v3]
Julian Waters
jwaters at openjdk.org
Wed Apr 3 02:31:11 UTC 2024
On Tue, 2 Apr 2024 20:10:12 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> I'm waiting for a bunch of tests to complete, so decided to just take that issue.
>
> https://github.com/openjdk/jdk/pull/18586
@kimbarrett I've been doing things to permit gcc/Windows, not clang. clang has too many different distributions on Windows for me to settle on one, and generalising all of them to be able to compile with any of the Windows clang distributions seamlessly and without issues sounds like a nightmare :P gcc on the other hand has just 2: MSYS2 MINGW64 with ucrt (Which is the one I'm working on) and standalone gcc Windows builds that link to ucrt
I haven't sent a cleanup in this area because I thought my changes were too specific to gcc/Windows, and wouldn't help much with HotSpot in general. I've learnt from my mistakes in the past where I caused reviewers pain in reviewing my admittedly selfish changes to HotSpot :(
That said, if it is requested of me, I can commit some cleanups to this file. What do you think?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18536#discussion_r1548833671
More information about the build-dev
mailing list