RFR: 8329816: Add SLEEF version 3.6.1 [v3]
Hamlin Li
mli at openjdk.org
Tue Aug 27 22:28:22 UTC 2024
On Tue, 27 Aug 2024 21:59:28 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:
>>> With this solution I would recommend putting the script next to the Sleef source tree instead of in make/devkit/.
>>
>>> The normal JDK build will just use the committed pre-generated headers.
>>
>>> Not because I didn't think it was feasible to implement, but because of the future maintenance burden.
>>
>> I agree with @erikj79, in particular the above 3 points.
>>
>> Shall we be ready to move forward? Or we're still blocked by some other issues, such as legal process?
>
> @Hamlin-Li We now have the necessary approvals in place for the new plan to include all of SLEEF (and the pre-generated header files) in the JDK. I (or somebody else from Oracle) will need to be the one committing/contributing the actual SLEEF code itself in the end. Can you take on the work of implementing the actual plan/logic and make sure it's all effectively ready for integration?
@vidmik Thanks for pushing forward this work.
Sure, I can take the work.
Just several questions, Sorry, as this is the first time I do this kind of work in jdk.
In this pr, we already have the pre-generated sleef files and the scripts to generate it, what we are missing is the sleef original file (in my understanding, we also need to checkin them), besides of sleef original files, do we need any other files or document? In particular, do you mind to clarify further about `plan/logic` mentioned above?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19185#issuecomment-2313681144
More information about the build-dev
mailing list