RFR: 8329816: Add SLEEF version 3.6.1 [v3]
Mikael Vidstedt
mikael at openjdk.org
Tue Aug 27 22:39:21 UTC 2024
On Tue, 27 Aug 2024 22:26:02 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> @Hamlin-Li We now have the necessary approvals in place for the new plan to include all of SLEEF (and the pre-generated header files) in the JDK. I (or somebody else from Oracle) will need to be the one committing/contributing the actual SLEEF code itself in the end. Can you take on the work of implementing the actual plan/logic and make sure it's all effectively ready for integration?
>
> @vidmik Thanks for pushing forward this work.
> Sure, I can take the work.
>
> Just several questions, Sorry, as this is the first time I do this kind of work in jdk.
> In this pr, we already have the pre-generated sleef files and the scripts to generate it, what we are missing is the sleef original file (in my understanding, we also need to checkin them), besides of sleef original files, do we need any other files or document? In particular, do you mind to clarify further about `plan/logic` mentioned above?
@Hamlin-Li Thank you for taking it on!
Part of the work is figuring out exactly what exactly we want - see the comments from @erikj79 and @theRealAph in this PR for inspiration. In particular, we'll want to include all or part of the SLEEF sources in the JDK, but we'll likely also want some additional build scripts and documentation to make it easy for developers to reproduce and update going forward. This could probably be based on the README and createSleef script.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19185#issuecomment-2313693092
More information about the build-dev
mailing list