RFR: 8339235: Fix indentation in build system

Magnus Ihse Bursie ihse at openjdk.org
Thu Aug 29 13:20:21 UTC 2024


On Thu, 29 Aug 2024 12:43:45 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> The indentation in the build system should be two spaces for logical indents, and four spaces for broken lines, period.
>> 
>> I searched for files starting with an odd number of spaces, and fixed those.
>
> make/CompileJavaModules.gmk line 78:
> 
>> 76: CreateHkTargets = \
>> 77:     $(call FilterExcludedTranslations, \
>> 78:       $(patsubst $(TOPDIR)/src/%, $(JDK_OUTPUTDIR)/modules/%, \
> 
> Isn't this a continuation?

Yep. I missed that. Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20763#discussion_r1736193343


More information about the build-dev mailing list