RFR: 8339235: Fix indentation in build system [v2]

Magnus Ihse Bursie ihse at openjdk.org
Thu Aug 29 13:24:32 UTC 2024


On Thu, 29 Aug 2024 12:44:29 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix incorrect indentation type
>
> make/autoconf/boot-jdk.m4 line 609:
> 
>> 607:         BUILD_JDK_FOUND=maybe
>> 608:         AC_MSG_NOTICE([Found potential Build JDK using configure arguments])
>> 609:       fi
> 
> And here?

Actually, I think this is correct. The block is logically indented inside the `([` and `])` start-of-block and end-of-block markers. Kind of the same reasons as all m4 macros (as created by `AC_DEFUN`) is indented two spaces, and not four.

We have precedence for this pattern elsewhere as well, e.g. at line 240 in this file.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20763#discussion_r1736199904


More information about the build-dev mailing list