RFR: 8345590: AIX 'make all' fails after JDK-8339480

Magnus Ihse Bursie ihse at openjdk.org
Thu Dec 12 22:48:36 UTC 2024


On Thu, 12 Dec 2024 18:00:33 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> make/Main.gmk line 1314:
>> 
>>> 1312: # all-images builds all our deliverables as images.
>>> 1313: ifeq ($(call isTargetOs, aix), true)
>>> 1314: all-images: product-images test-image all-docs-images
>> 
>> I think you should indent the all-images line like in the other places.
>
> Yes please use indentation and avoid repeating code.
> Suggestion:
> 
> all-images: product-images test-image all-docs-images
> ifeq ($(call isTargetOs, aix), false)
>   all-images: static-jdk-image
> endif

Eriks suggestion is almost okay, but you should filter on the supported platforms for static images instead, that is, check `ifeq ($(call isTargetOs, linux macosx), true)` instead.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22713#discussion_r1882991203


More information about the build-dev mailing list