RFR: 8345590: AIX 'make all' fails after JDK-8339480
Matthias Baesken
mbaesken at openjdk.org
Fri Dec 13 08:07:36 UTC 2024
On Thu, 12 Dec 2024 22:46:16 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Yes please use indentation and avoid repeating code.
>> Suggestion:
>>
>> all-images: product-images test-image all-docs-images
>> ifeq ($(call isTargetOs, aix), false)
>> all-images: static-jdk-image
>> endif
>
> Eriks suggestion is almost okay, but you should filter on the supported platforms for static images instead, that is, check `ifeq ($(call isTargetOs, linux macosx), true)` instead.
Hi Magnus, what about Windows ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22713#discussion_r1883520621
More information about the build-dev
mailing list