RFR: 8346377: Properly support static builds for Windows
Erik Joelsson
erikj at openjdk.org
Thu Dec 19 22:18:41 UTC 2024
On Tue, 17 Dec 2024 15:41:51 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> When the static launcher was introduced in [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480), due to time and resource constraints, it was only working properly on Linux and macOS, while the Windows port compiled but did not work. Now the time has come to fix that.
>
> Most of the changes mirrors the kind of changes that were made for Linux and macOS in JDK-8339480. There are still limitations to static builds on Windows (e.g. starting with a splashscreen), but these kind of limitations also exists on the other platforms.
>
> Note that this PR is blocked by [JDK-8346433](https://bugs.openjdk.org/browse/JDK-8346433), [JDK-8346195](https://bugs.openjdk.org/browse/JDK-8346195), [JDK-8346378](https://bugs.openjdk.org/browse/JDK-8346378), [JDK-8346383](https://bugs.openjdk.org/browse/JDK-8346383), [JDK-8346388](https://bugs.openjdk.org/browse/JDK-8346388) and [JDK-8346394](https://bugs.openjdk.org/browse/JDK-8346394), which must be integrated before this one.
src/hotspot/os/windows/os_windows.cpp line 316:
> 314: }
> 315:
> 316: // Get rid of \hotspot_variant>, if binary is libjvm.so,
libjvm.so -> jvm.dll?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22795#discussion_r1893202914
More information about the build-dev
mailing list