RFR: 8346377: Properly support static builds for Windows [v2]

Magnus Ihse Bursie ihse at openjdk.org
Fri Dec 20 13:11:22 UTC 2024


On Thu, 19 Dec 2024 22:10:29 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix comment
>
> src/hotspot/os/windows/os_windows.cpp line 316:
> 
>> 314:         }
>> 315: 
>> 316:         // Get rid of \hotspot_variant>, if binary is libjvm.so,
> 
> libjvm.so -> jvm.dll?

Good catch. I copied and adapted this code from the unix solution, but missed this. Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22795#discussion_r1893921085


More information about the build-dev mailing list