RFR: 8325342: Remove unneeded exceptions in compare.sh

[Magnus Ihse Bursie]

On Tue, 6 Feb 2024 17:54:24 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Over time, we have been better at addressing inconsistencies in the build, but the exceptions put in place in compare.sh have not been updated to reflect this.
>> 
>> This attempts to make sure we only keep those exceptions that are currently actually needed to verify a reproducible build (the primary usecase for the compare script these days).
>> 
>> I also discovered bugs in the script, where mismatches in a zip file did not make us report a failed comparison. I added extra code to make sure we always set the REGRESSION flag whenever we detect a problem.
>
> make/scripts/compare.sh line 298:
> 
>> 296:         | $GREP -v "/hotspot/gtest/server/gtestLauncher" \
>> 297:         | $GREP -v "/hotspot/gtest/server/libjvm.dylib" \
>> 298:         | $SORT | $FILTER)
> 
> This list of exclusion, or at least most of it, isn't for handling exceptions but because those files are handled explicitly by other comparison functions.

I see. I'll split it into two parts then, one that deselects files that are guaranteed to be processed elsewhere, and one to filter out problematic files (currently only the gtest binaries and *.pdb).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17735#discussion_r1481096939