RFR: 8325342: Remove unneeded exceptions in compare.sh [v2]
Magnus Ihse Bursie
ihse at openjdk.org
Wed Feb 21 17:27:21 UTC 2024
> Over time, we have been better at addressing inconsistencies in the build, but the exceptions put in place in compare.sh have not been updated to reflect this.
>
> This attempts to make sure we only keep those exceptions that are currently actually needed to verify a reproducible build (the primary usecase for the compare script these days).
>
> I also discovered bugs in the script, where mismatches in a zip file did not make us report a failed comparison. I added extra code to make sure we always set the REGRESSION flag whenever we detect a problem.
Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision:
- Restore jar_contents exception
- Do not compare .pdb files
- Assume GraphViz non-determinism has been fixed in 9.0
- Remove jar_contents exception
- Test debug symbol files separately, for clarity
- Merge branch 'master' into remove-compare-exceptions
- Also fix windows debug files
- Do not make debuginfo files executable
- Add support for linux debug files
- Separate out debug files
- ... and 7 more: https://git.openjdk.org/jdk/compare/ea3a6757...2db17083
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/17735/files
- new: https://git.openjdk.org/jdk/pull/17735/files/5a4efc40..2db17083
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=17735&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=17735&range=00-01
Stats: 37386 lines in 1230 files changed: 16781 ins; 13112 del; 7493 mod
Patch: https://git.openjdk.org/jdk/pull/17735.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/17735/head:pull/17735
PR: https://git.openjdk.org/jdk/pull/17735
More information about the build-dev
mailing list