Integrated: 8325342: Remove unneeded exceptions in compare.sh
Magnus Ihse Bursie
ihse at openjdk.org
Wed Feb 21 22:37:57 UTC 2024
On Tue, 6 Feb 2024 16:53:37 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> Over time, we have been better at addressing inconsistencies in the build, but the exceptions put in place in compare.sh have not been updated to reflect this.
>
> This attempts to make sure we only keep those exceptions that are currently actually needed to verify a reproducible build (the primary usecase for the compare script these days).
>
> I also discovered bugs in the script, where mismatches in a zip file did not make us report a failed comparison. I added extra code to make sure we always set the REGRESSION flag whenever we detect a problem.
This pull request has now been integrated.
Changeset: 0bcece99
Author: Magnus Ihse Bursie <ihse at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/0bcece995840777db660811e4b20bb018e90439b
Stats: 352 lines in 2 files changed: 137 ins; 167 del; 48 mod
8325342: Remove unneeded exceptions in compare.sh
Reviewed-by: erikj
-------------
PR: https://git.openjdk.org/jdk/pull/17735
More information about the build-dev
mailing list