RFR: 8325342: Remove unneeded exceptions in compare.sh

[Magnus Ihse Bursie]

On Tue, 6 Feb 2024 16:53:37 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Over time, we have been better at addressing inconsistencies in the build, but the exceptions put in place in compare.sh have not been updated to reflect this.
> 
> This attempts to make sure we only keep those exceptions that are currently actually needed to verify a reproducible build (the primary usecase for the compare script these days).
> 
> I also discovered bugs in the script, where mismatches in a zip file did not make us report a failed comparison. I added extra code to make sure we always set the REGRESSION flag whenever we detect a problem.

Ok, new try. I have redesigned how we discover files. Now we start by finding *all* files that we should compare, and then we partition out libs, zips, etc. What remains are the "other" files, so we will be sure to always check every file. I split up "other" files in two parts, debug symbol files and the "other" files proper.

I have also removed a few more exceptions I found. I have run this like 7-8 times in our CI system to check that we did not get any intermittent failures. They might still be possible, but at least they are somewhat rare. If they show up, we'll just have to reinstantiate the exception, and perhaps document it better, so we know when we can actually remove it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17735#issuecomment-1957399340