RFR: 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234 [v2]

Bernhard Urban-Forster burban at openjdk.org
Fri Feb 23 11:37:53 UTC 2024


On Fri, 23 Feb 2024 11:11:19 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/assembler_aarch64.cpp line 122:
>> 
>>> 120:   }
>>> 121: 
>>> 122:   void das1(uintptr_t insn) {
>> 
>> Doesn't this need to be exported for debugging on Windows-Aarch64?
>
> Ah, right, there is a Windows/aarch64 port. Forgot about it. :(
> 
> I don't know who maintains/cares about that port anymore. Pinging @mo-beck @lewurm @luhenry. Do anyone of you care about this anymore? If not, do you know if anyone has taken up the baton? (Or maybe it's time to retire the Windows/aarch64 port)

cc @karianna @gdams, is there a Windows/AArch64 owner?

> Or maybe it's time to retire the Windows/aarch64 port

I guess Windows/AArch64 as a platform hasn't really taken off _yet_, give it a few more years 😉 I certainly would not advocate for removing it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17967#discussion_r1500542216


More information about the build-dev mailing list