RFR: 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234 [v2]

Bernhard Urban-Forster burban at openjdk.org
Fri Feb 23 12:05:57 UTC 2024


On Fri, 23 Feb 2024 11:41:04 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> cc @karianna @gdams, is there a Windows/AArch64 owner?
>> 
>>> Or maybe it's time to retire the Windows/aarch64 port
>> 
>> I guess Windows/AArch64 as a platform hasn't really taken off _yet_, give it a few more years 😉 I certainly would not advocate for removing it.
>
> Instead of discussing removal of windows/aarch64 (although the general rule in OpenJDK is that ports that are not maintained by anyone should be removed); let's stick to the question here: do we need to export `das1()` for debugging?

Personally I have never used `das`/`das1` on any AArch64 port when debugging.  I guess it was somewhat handy when the backend was originally developed.  I would argue that the built-in disassembler of any debugger and `disnm` from `debug.cpp` are good enough, and thus `das`/`das1` can be removed.  What do you think @theRealAph ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17967#discussion_r1500568587


More information about the build-dev mailing list