RFR: 8326585: COMPARE_BUILD=PATCH fails if patch -R fails

Magnus Ihse Bursie ihse at openjdk.org
Fri Feb 23 15:22:13 UTC 2024


At the end of a COMPARE_BUILD run with a patch file, the build tries to revert the patch to restore the workspace as it was. On some versions of patch, this fails if one or more files were deleted, causing the makefile to abort just before the actual comparison. :-(

Reverting the patch is just a courtesy act for running on a developer workspace, so even if this fails, we should continue with the comparison.

-------------

Commit messages:
 - 8326585: COMPARE_BUILD=PATCH fails if patch -R fails

Changes: https://git.openjdk.org/jdk/pull/17983/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17983&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8326585
  Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/17983.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17983/head:pull/17983

PR: https://git.openjdk.org/jdk/pull/17983


More information about the build-dev mailing list