RFR: 8326585: COMPARE_BUILD=PATCH fails if patch -R fails

Erik Joelsson erikj at openjdk.org
Fri Feb 23 17:26:52 UTC 2024


On Fri, 23 Feb 2024 15:18:11 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> At the end of a COMPARE_BUILD run with a patch file, the build tries to revert the patch to restore the workspace as it was. On some versions of patch, this fails if one or more files were deleted, causing the makefile to abort just before the actual comparison. :-(
> 
> Reverting the patch is just a courtesy act for running on a developer workspace, so even if this fails, we should continue with the comparison.

Marked as reviewed by erikj (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17983#pullrequestreview-1898603155


More information about the build-dev mailing list