RFR: 8326587: Separate out Microsoft toolchain linking [v4]
Magnus Ihse Bursie
ihse at openjdk.org
Mon Feb 26 11:03:19 UTC 2024
> There is not much overlap on how linking is done on Windows on one hand, and on all Unix platforms on the other. This makes Link.gmk basically consists of two parts, each in it own half of if statements, and the few common parts are artificially shoehorned in to fit both sides.
>
> The code will be much clearer if we just split this into two different files.
>
> Note that this PR slightly collides with JDK-8326583 (https://github.com/openjdk/jdk/pull/17986). Whichever of this goes in first will mean that the other one needs to make some adaptations.
Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
Fix indentation
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/17987/files
- new: https://git.openjdk.org/jdk/pull/17987/files/afd1edd7..1bdc1350
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=17987&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=17987&range=02-03
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/17987.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/17987/head:pull/17987
PR: https://git.openjdk.org/jdk/pull/17987
More information about the build-dev
mailing list