RFR: 8326587: Separate out Microsoft toolchain linking [v4]
Erik Joelsson
erikj at openjdk.org
Mon Feb 26 14:32:54 UTC 2024
On Mon, 26 Feb 2024 11:03:19 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> There is not much overlap on how linking is done on Windows on one hand, and on all Unix platforms on the other. This makes Link.gmk basically consists of two parts, each in it own half of if statements, and the few common parts are artificially shoehorned in to fit both sides.
>>
>> The code will be much clearer if we just split this into two different files.
>>
>> Note that this PR slightly collides with JDK-8326583 (https://github.com/openjdk/jdk/pull/17986). Whichever of this goes in first will mean that the other one needs to make some adaptations.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix indentation
Marked as reviewed by erikj (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/17987#pullrequestreview-1901031264
More information about the build-dev
mailing list