RFR: 8326953: Possible race in creation of win-exports.def [v2]

Magnus Ihse Bursie ihse at openjdk.org
Wed Feb 28 14:53:13 UTC 2024


> We have seen a build failure along the lines of:
> 
>  /usr/bin/mv: cannot move '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def.tmp' to '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def': No such file or directory
> 
> on Windows.
> 
> My guess is that this is a race between creating the win-export.def file for the gtest jvm and the product jvm.

Magnus Ihse Bursie has updated the pull request incrementally with four additional commits since the last revision:

 - Use $(BUILD_LIBJVM_OBJECT_DIR) to work properly with static libs
 - Better attempt with keeping the win-exports file for static libs
 - Disable win-export.def on static libs
 - Make it proper $(eval $(call ...))

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18043/files
  - new: https://git.openjdk.org/jdk/pull/18043/files/2fa57610..f574d063

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18043&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18043&range=00-01

  Stats: 21 lines in 2 files changed: 7 ins; 1 del; 13 mod
  Patch: https://git.openjdk.org/jdk/pull/18043.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18043/head:pull/18043

PR: https://git.openjdk.org/jdk/pull/18043


More information about the build-dev mailing list