RFR: 8326953: Possible race in creation of win-exports.def [v2]

[Erik Joelsson]

On Wed, 28 Feb 2024 14:53:13 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> We have seen a build failure along the lines of:
>> 
>>  /usr/bin/mv: cannot move '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def.tmp' to '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def': No such file or directory
>> 
>> on Windows.
>> 
>> My guess is that this is a race between creating the win-export.def file for the gtest jvm and the product jvm.
>
> Magnus Ihse Bursie has updated the pull request incrementally with four additional commits since the last revision:
> 
>  - Use $(BUILD_LIBJVM_OBJECT_DIR) to work properly with static libs
>  - Better attempt with keeping the win-exports file for static libs
>  - Disable win-export.def on static libs
>  - Make it proper $(eval $(call ...))

The race was just between the dynamic and static build of libjvm. I don't think we need or should create a separate defs file for gtest, that's just unnecessary complexity.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18043#pullrequestreview-1906513460