RFR: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16 [v2]

[Aleksey Shipilev]

On Fri, 26 Jan 2024 19:33:49 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Current GHA runs produce lots of warnings:
>> 
>> Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache at v3, actions/download-artifact at v3, actions/upload-artifact at v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
>> 
>> We can upgrade to new actions to get the Node20.
>> 
>> Release/migration notes:
>> https://github.com/actions/cache#whats-new
>> https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md
>> https://github.com/actions/download-artifact/blob/main/docs/MIGRATION.md
>> https://github.com/actions/github-script#breaking-changes
>> 
>> There is also msys2/setup-msys2, which was pinned by [JDK-8310259](https://bugs.openjdk.org/browse/JDK-8310259). We need at least 2.21.0 to get Node 20:
>> https://github.com/msys2/setup-msys2/blob/main/CHANGELOG.md. I think we can unpin msys2 at this point.
>> 
>> I don't think any of the migration problems outlined in those notes apply to our workflows.
>> 
>> Additional testing:
>>  - [x] 3x GHA with cleaned caches
>>  - [x]  3x GHA with populated caches (default)
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Also update github-script

I think the following would be a sane plan for this year:

Push this PR to mainline. Wait 4 weeks and see if there is any fallout from this. Provided there is no fallout, backport this to 21u-dev, 17u-dev, 11u-dev. This gets the changes to update releases repos and starts testing it there. The April releases would not be affected, since we would plan for integration past the fork for April stabilization. Provided there is no fallout in update release trees, we would have all pipelines at Node 20 actions by June release. 

I don't think GitHub has set a firm date for Node 16 removal -- the [note](https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/) says "Our plan is to transition all actions to run on Node 20 by Spring 2024." -- which I assume means there would be some window while older actions still run.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17572#issuecomment-1914431540