RFR: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16 [v2]

[Magnus Ihse Bursie]

On Fri, 26 Jan 2024 19:33:49 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Current GHA runs produce lots of warnings:
>> 
>> Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache at v3, actions/download-artifact at v3, actions/upload-artifact at v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
>> 
>> We can upgrade to new actions to get the Node20.
>> 
>> Release/migration notes:
>> https://github.com/actions/cache#whats-new
>> https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md
>> https://github.com/actions/download-artifact/blob/main/docs/MIGRATION.md
>> https://github.com/actions/github-script#breaking-changes
>> 
>> There is also msys2/setup-msys2, which was pinned by [JDK-8310259](https://bugs.openjdk.org/browse/JDK-8310259). We need at least 2.21.0 to get Node 20:
>> https://github.com/msys2/setup-msys2/blob/main/CHANGELOG.md. I think we can unpin msys2 at this point.
>> 
>> I don't think any of the migration problems outlined in those notes apply to our workflows.
>> 
>> Additional testing:
>>  - [x] 3x GHA with cleaned caches
>>  - [x]  3x GHA with populated caches (default)
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Also update github-script

Looks good to me. 

I'm not even sure why you are calling this "unpinning" of msys. You are fixing it at `@v2.22.0`. Unless the msys action is in the habit of releasing new updates with the same patch version, then this is in effect a pin. The difference is just that the previous pin was for a specific commit, rather than a released version, which is (in my eyes) a markedly worse strategy. (I guess we did that, instead of reverting to a specific released version, due to problems finding a working version, but I don't remember).

To really "unpin" msys would be to require just a specific major version, like `msys2/setup-msys2 at v2`. You are not doing that, and I don't recommend doing that. :-)

-------------

Marked as reviewed by ihse (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17572#pullrequestreview-1848440526