RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v5]

[Kim Barrett]

On Mon, 24 Jun 2024 14:34:37 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

>> fastdebug:
>> 
>> 
>> # A fatal error has been detected by the Java Runtime Environment:
>> #
>> #  Internal Error (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77), pid=878152, tid=878158
>> #  assert(_thread->is_in_live_stack((address)this)) failed: not on stack?
>> #
>> # JRE version:  (24.0) (fastdebug build )
>> # Java VM: OpenJDK 64-Bit Server VM (fastdebug 24-internal-adhoc.azul.openjdk-git, mixed mode, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64)
>> # Problematic frame:
>> # V  [libjvm.so+0x1d20658]  constantPoolHandle::constantPoolHandle(Thread*, ConstantPool*)+0x268
>
> Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change the comment
>    - suggested by Thomas Stuefe

Changes requested by kbarrett (Reviewer).

make/autoconf/jdk-options.m4 line 449:

> 447:           if test "x$TOOLCHAIN_TYPE" = "xclang"; then
> 448:             ASAN_CFLAGS="$ASAN_CFLAGS -fsanitize-address-use-after-return=never"
> 449:           fi

This is JDK-wide configuration.  Do we need that?  Or would it be sufficient to limit this to the JVM?
I'm not sure what would happen with fake stacks at the JVM boundary (in either direction).  I also don't
know what happens at the boundary with non-JDK native code.

make/autoconf/jdk-options.m4 line 449:

> 447:           if test "x$TOOLCHAIN_TYPE" = "xclang"; then
> 448:             ASAN_CFLAGS="$ASAN_CFLAGS -fsanitize-address-use-after-return=never"
> 449:           fi

There's no change being made for the microsoft toolchain.  It seems like the same issues with the fake stack
should arise there.

-------------

PR Review: https://git.openjdk.org/jdk/pull/19843#pullrequestreview-2136519085
PR Review Comment: https://git.openjdk.org/jdk/pull/19843#discussion_r1651470854
PR Review Comment: https://git.openjdk.org/jdk/pull/19843#discussion_r1651472040