RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v5]

[Kim Barrett]

On Mon, 24 Jun 2024 18:42:34 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change the comment
>>    - suggested by Thomas Stuefe
>
> make/autoconf/jdk-options.m4 line 449:
> 
>> 447:           if test "x$TOOLCHAIN_TYPE" = "xclang"; then
>> 448:             ASAN_CFLAGS="$ASAN_CFLAGS -fsanitize-address-use-after-return=never"
>> 449:           fi
> 
> This is JDK-wide configuration.  Do we need that?  Or would it be sufficient to limit this to the JVM?
> I'm not sure what would happen with fake stacks at the JVM boundary (in either direction).  I also don't
> know what happens at the boundary with non-JDK native code.

Thinking about it some more, global disable seems like the only safe thing to do.  So never mind my musings
about whether the disable could be limited to the JVM.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19843#discussion_r1654034653