RFR: 8327173: HotSpot Style Guide needs update regarding nullptr vs NULL

[Aleksey Shipilev]

On Mon, 4 Mar 2024 08:38:09 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change to update the HotSpot Style Guide's discussion of
> nullptr and its use.
> 
> I suggest this is an editorial rather than substantive change to the style
> guide.  As such, the normal HotSpot PR process can be used for this change.

Looks okay, but questions/suggestions:

doc/hotspot-style.md line 738:

> 736: expressions with value zero.  C++14 replaced that with integer literals with
> 737: value zero.  Some compilers continue to treat a zero-valued integral constant
> 738: expressions as a _null pointer constant_ even in C++14 mode.

It is not very clear why should this concern any Hotspot developers?

-------------

PR Review: https://git.openjdk.org/jdk/pull/18101#pullrequestreview-1913874746
PR Review Comment: https://git.openjdk.org/jdk/pull/18101#discussion_r1510891459