RFR: 8327173: HotSpot Style Guide needs update regarding nullptr vs NULL [v2]

[Kim Barrett]

On Mon, 4 Mar 2024 09:52:15 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   respond to shipilev comments
>
> doc/hotspot-style.md line 738:
> 
>> 736: expressions with value zero.  C++14 replaced that with integer literals with
>> 737: value zero.  Some compilers continue to treat a zero-valued integral constant
>> 738: expressions as a _null pointer constant_ even in C++14 mode.
> 
> It is not very clear why should this concern any Hotspot developers?

If one is familiar with C++14 (or later) or were to look up _null pointer
constant_ in the C++14 standard, one might wonder why this style guide
admonishes against using non-literal constant expressions for such. But I've
rewritten the part about 0 as a pointer to (I think) make things clearer.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18101#discussion_r1512225238