RFR: 8327460: Compile tests with the same visibility rules as product code [v2]

Erik Joelsson erikj at openjdk.org
Wed Mar 6 13:51:46 UTC 2024


On Wed, 6 Mar 2024 13:43:00 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Currently, our symbol visibility handling for tests are sloppy; we only handle it properly on Windows. We need to bring it up to the same levels as product code. This is a prerequisite for [JDK-8327045](https://bugs.openjdk.org/browse/JDK-8327045), which in turn is a building block for Hermetic Java.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update line number for dereference_null  in TestDwarf

Build system changes look good to me. The specific test changes probably needs other reviewers.

I assume you have run all the affected tests on a wide variety of platforms?

-------------

Marked as reviewed by erikj (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18135#pullrequestreview-1919814110


More information about the build-dev mailing list