RFR: 8327460: Compile tests with the same visibility rules as product code [v2]

Magnus Ihse Bursie ihse at openjdk.org
Wed Mar 6 13:55:46 UTC 2024


On Wed, 6 Mar 2024 13:43:00 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Currently, our symbol visibility handling for tests are sloppy; we only handle it properly on Windows. We need to bring it up to the same levels as product code. This is a prerequisite for [JDK-8327045](https://bugs.openjdk.org/browse/JDK-8327045), which in turn is a building block for Hermetic Java.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update line number for dereference_null  in TestDwarf

I have run the tests in tier1, tier2 and tier3 on the Oracle internal CI, which includes linux/x64, linux/aarch64, windows/x64, macosx/x64 and macosx/aarch64. 

I am currently running tier 4-10; this will take a while (and I won't integrate until this has finished running). When running multiple high-tier tests like this, the likelihood that I encounter intermittent problems increase. I will ignore test failures that seem likely to be intermittent and not caused by this patch. I might be overdoing the testing, but since this change affects **all** native tests, I want to be absolutely sure I don't break any tests that only execute as part of a high tier.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18135#issuecomment-1980924971


More information about the build-dev mailing list