RFR: 8328074: Add jcheck whitespace checking for assembly files
Julian Waters
jwaters at openjdk.org
Wed Mar 13 11:29:14 UTC 2024
On Wed, 13 Mar 2024 11:18:20 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> As part of the ongoing effort to enable jcheck whitespace checking to all text files, it is now time to address assembly (.S) files. The hotspot assembly files were fixed as part of the hotspot mapfile removal, so only a single incorrect jdk library remains.
>
> The main issue with `libjsvml` was inconsistent line starts, sometimes using tabs. I used the `expand` unix command line tool to replace these with spaces.
src/jdk.incubator.vector/linux/native/libjsvml/jsvml_d_acos_linux_x86.S line 37:
> 35: .text
> 36: # mark_begin;
> 37: .align 16,0x90
.align seems to ironically not be aligned with the rest of the directives
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18268#discussion_r1523048988
More information about the build-dev
mailing list