RFR: 8328074: Add jcheck whitespace checking for assembly files [v3]
Magnus Ihse Bursie
ihse at openjdk.org
Wed Mar 13 11:59:37 UTC 2024
On Wed, 13 Mar 2024 11:26:14 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> Magnus Ihse Bursie has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. The pull request now contains two commits:
>>
>> - Enable jcheck whitespace checks for .S files
>> - Run expand on libjsvml
>
> src/jdk.incubator.vector/linux/native/libjsvml/jsvml_d_acos_linux_x86.S line 37:
>
>> 35: .text
>> 36: # mark_begin;
>> 37: .align 16,0x90
>
> .align seems to ironically not be aligned with the rest of the directives
Bad indentation like this is not something jcheck can detect or will complain about. However, I agree that it looks horrible. What's more, this seem to be problematic in multiple locations -- many, but not all, instances of `.align` (and `ALIGN` on Windows) are unaligned. I guess it is due to copy/paste error.
I'm sort of reluctant to fix this in this PR, but then again, it just looks too bad.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18268#discussion_r1523085132
More information about the build-dev
mailing list