RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v3]

[Magnus Ihse Bursie]

On Fri, 15 Mar 2024 11:31:08 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you help to review this patch?
>> Thanks
>> 
>> This is a continuation of work based on [1] by @XiaohongGong, most work was done in that pr. In this new pr, just rebased the code in [1], then added some minor changes (renaming of calling method, add libsleef as extra lib in CI cross-build on aarch64 in github workflow); I aslo tested the combination of following scenarios:
>> * at build time
>>   * with/without sleef
>>   * with/without sve support 
>> * at runtime
>>   * with/without sleef
>>   * with/without sve support 
>> 
>> [1] https://github.com/openjdk/jdk/pull/16234
>> 
>> ## Regression Test
>> * test/jdk/jdk/incubator/vector/
>> * test/hotspot/jtreg/compiler/vectorapi/
>> 
>> ## Performance Test
>> Previously, @XiaohongGong has shared the data: https://github.com/openjdk/jdk/pull/16234#issuecomment-1767727028
>
> Hamlin Li has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - rename
>  - resolve magicus's comments

src/jdk.incubator.vector/linux/native/libvectormath/vector_math_neon.c line 25:

> 23: 
> 24: #include <sleef.h>
> 25: #include <jni_md.h>

You should not include the "_md" (machine dependent) part of jni directly.

Suggestion:

#include <jni.h>

src/jdk.incubator.vector/linux/native/libvectormath/vector_math_sve.c line 25:

> 23: 
> 24: #include <sleef.h>
> 25: #include <jni_md.h>

Same here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18294#discussion_r1526173179
PR Review Comment: https://git.openjdk.org/jdk/pull/18294#discussion_r1526174098