RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v3]

Hamlin Li mli at openjdk.org
Fri Mar 15 13:58:05 UTC 2024


On Fri, 15 Mar 2024 11:55:14 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - rename
>>  - resolve magicus's comments
>
> src/jdk.incubator.vector/linux/native/libvectormath/vector_math_neon.c line 25:
> 
>> 23: 
>> 24: #include <sleef.h>
>> 25: #include <jni_md.h>
> 
> You should not include the "_md" (machine dependent) part of jni directly.
> 
> Suggestion:
> 
> #include <jni.h>

Thanks, fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18294#discussion_r1526325331


More information about the build-dev mailing list