RFR: 8311302: Implement JEP 493: Linking Run-Time Images without JMODs [v45]

[Mandy Chung]

On Wed, 6 Nov 2024 11:24:23 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Please review this patch which adds a jlink mode to the JDK which doesn't need the packaged modules being present. A.k.a run-time image based jlink. Fundamentally this patch adds an option to use `jlink` even though your JDK install might not come with the packaged modules (directory `jmods`). This is particularly useful to further reduce the size of a jlinked runtime. After the removal of the concept of a JRE, a common distribution mechanism is still the full JDK with all modules and packaged modules. However, packaged modules can incur an additional size tax. For example in a container scenario it could be useful to have a base JDK container including all modules, but without also delivering the packaged modules. This comes at a size advantage of `~25%`. Such a base JDK container could then be used to `jlink` application specific runtimes, further reducing the size of the application runtime image (App + JDK runtime; as a single image *or* separate bundles, depending on the app 
 being modularized).
>> 
>> The basic design of this approach is to add a jlink plugin for tracking non-class and non-resource files of a JDK install. I.e. files which aren't present in the jimage (`lib/modules`). This enables producing a `JRTArchive` class which has all the info of what constitutes the final jlinked runtime.
>> 
>> Basic usage example:
>> 
>> $ diff -u <(./bin/java --list-modules --limit-modules java.se) <(../linux-x86_64-server-release/images/jdk/bin/java --list-modules --limit-modules java.se)
>> $ diff -u <(./bin/java --list-modules --limit-modules jdk.jlink) <(../linux-x86_64-server-release/images/jdk/bin/java --list-modules --limit-modules jdk.jlink)
>> $ ls ../linux-x86_64-server-release/images/jdk/jmods
>> java.base.jmod            java.net.http.jmod       java.sql.rowset.jmod      jdk.crypto.ec.jmod         jdk.internal.opt.jmod                     jdk.jdi.jmod         jdk.management.agent.jmod  jdk.security.auth.jmod
>> java.compiler.jmod        java.prefs.jmod          java.transaction.xa.jmod  jdk.dynalink.jmod          jdk.internal.vm.ci.jmod                   jdk.jdwp.agent.jmod  jdk.management.jfr.jmod    jdk.security.jgss.jmod
>> java.datatransfer.jmod    java.rmi.jmod            java.xml.crypto.jmod      jdk.editpad.jmod           jdk.internal.vm.compiler.jmod             jdk.jfr.jmod         jdk.management.jmod        jdk.unsupported.desktop.jmod
>> java.desktop.jmod         java.scripting.jmod      java.xml.jmod             jdk.hotspot.agent.jmod     jdk.i...
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 180 commits:
> 
>  - Merge branch 'master' into jdk-8311302-jmodless-link
>  - Make capability in --help human readable
>  - Fix comment
>  - Fix SystemModulesTest2 when linkable runtime but no packaged modules
>  - Rename PackagedModulesVsJmodLessTest => PackagedModulesVsRuntimeImageLinkTest
>  - Rename JmodLess => runtimeImage
>  - Refactor tests so that they run for default build
>    
>    When a default JDK build is being produced, the tests create a run-time
>    image capable JDK as an interim step before everything else is being
>    verified.
>    
>    For a build that has the run-time image link capability already turned
>    on, this extra step is being omitted.
>  - Mandy's feedback
>  - Merge branch 'master' into jdk-8311302-jmodless-link
>  - Some test fixes
>  - ... and 170 more: https://git.openjdk.org/jdk/compare/83f3d42d...e83b9584

I reviewed and approved the source changes.   For the test changes, I believe multiple `@test` tags to verify a JDK of linkable run-time image and another JDK with packaged modules are not necessary.  Each test execution can only verify one JDK.  The tests can keep one single `@test` and the main method has to determine the test JDK configuration for test verification.

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JRTArchive.java line 132:

> 130:         } catch (RuntimeImageLinkException e) {
> 131:             // populate modified files exception
> 132:             throw e;

It's unchecked exception and this catch clause can be dropped.

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/runtimelink/RuntimeImageLinkException.java line 45:

> 43:     public RuntimeImageLinkException(String file, Reason reason) {
> 44:         this.file = file;
> 45:         this.reason = reason;

Suggestion:

        this.file = Objects.requireNonNull(file);
        this.reason = Objects.requireNonNull(reason);

src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties line 126:

> 124: \ and cannot be used to create another image with the jdk.jlink module
> 125: err.runtime.link.packaged.mods=This JDK has no packaged modules.\
> 126: \ --keep-packaged-modules is not supported.

Suggestion:

err.runtime.link.packaged.mods=This JDK has no packaged modules.\
\ --keep-packaged-modules is not supported

-------------

PR Review: https://git.openjdk.org/jdk/pull/14787#pullrequestreview-2419929066
PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1832055001
PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1832055943
PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1832040227