RFR: 8311302: Implement JEP 493: Linking Run-Time Images without JMODs [v45]

Severin Gehwolf sgehwolf at openjdk.org
Thu Nov 7 13:15:05 UTC 2024


On Thu, 7 Nov 2024 05:00:46 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 180 commits:
>> 
>>  - Merge branch 'master' into jdk-8311302-jmodless-link
>>  - Make capability in --help human readable
>>  - Fix comment
>>  - Fix SystemModulesTest2 when linkable runtime but no packaged modules
>>  - Rename PackagedModulesVsJmodLessTest => PackagedModulesVsRuntimeImageLinkTest
>>  - Rename JmodLess => runtimeImage
>>  - Refactor tests so that they run for default build
>>    
>>    When a default JDK build is being produced, the tests create a run-time
>>    image capable JDK as an interim step before everything else is being
>>    verified.
>>    
>>    For a build that has the run-time image link capability already turned
>>    on, this extra step is being omitted.
>>  - Mandy's feedback
>>  - Merge branch 'master' into jdk-8311302-jmodless-link
>>  - Some test fixes
>>  - ... and 170 more: https://git.openjdk.org/jdk/compare/83f3d42d...e83b9584
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/runtimelink/RuntimeImageLinkException.java line 45:
> 
>> 43:     public RuntimeImageLinkException(String file, Reason reason) {
>> 44:         this.file = file;
>> 45:         this.reason = reason;
> 
> Suggestion:
> 
>         this.file = Objects.requireNonNull(file);
>         this.reason = Objects.requireNonNull(reason);

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1832657318


More information about the build-dev mailing list