RFR: 8268895: Do not filter out man pages from build
David Holmes
dholmes at openjdk.org
Fri Nov 8 01:46:47 UTC 2024
On Wed, 6 Nov 2024 16:27:42 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> Due to historical reasons, Oracle builds of OpenJDK do not include the man pages that are present in the OpenJDK source repo. Oracle JDK builds include man pages, and most likely all other OpenJDK builds.
>
> There is no need to leave out the man pages; nor to even have a mechanism for doing so.
One nit on terminology, but otherwise looks good.
Thanks
make/autoconf/jdk-options.m4 line 641:
> 639: ################################################################################
> 640: #
> 641: # Optionally disable man pages (deprecated)
Elsewhere in JDK "deprecated" means "still works but don't use it", whereas here (and perhaps in build system overall?) it means "ignored but doesn't cause an error".
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21936#pullrequestreview-2422514489
PR Review Comment: https://git.openjdk.org/jdk/pull/21936#discussion_r1833585983
More information about the build-dev
mailing list