RFR: 8268895: Do not filter out man pages from build

[Magnus Ihse Bursie]

On Fri, 8 Nov 2024 01:43:09 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Due to historical reasons, Oracle builds of OpenJDK do not include the man pages that are present in the OpenJDK source repo. Oracle JDK builds include man pages, and most likely all other OpenJDK builds.
>> 
>> There is no need to leave out the man pages; nor to even have a mechanism for doing so.
>
> make/autoconf/jdk-options.m4 line 641:
> 
>> 639: ################################################################################
>> 640: #
>> 641: # Optionally disable man pages (deprecated)
> 
> Elsewhere in JDK "deprecated" means "still works but don't use it", whereas here (and perhaps in build system overall?) it means "ignored but doesn't cause an error".

Yeah, you are right. I actually had the same thought when changing this. I don't know how this came to be. Obviously, I am to blame, since I created the `UTIL_DEPRECATED_ARG_ENABLE` function. :-) What I mean is, I don't really understand why I thought "deprecated" was a good way to describe this.

I opened https://bugs.openjdk.org/browse/JDK-8343817 to deal with this systematically in the entire build system. Are you ok with keeping this in line with the rest of the build system for now?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21936#discussion_r1833994704