RFR: 8268895: Do not filter out man pages from build

David Holmes dholmes at openjdk.org
Sat Nov 9 01:24:21 UTC 2024


On Fri, 8 Nov 2024 09:20:50 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> make/autoconf/jdk-options.m4 line 641:
>> 
>>> 639: ################################################################################
>>> 640: #
>>> 641: # Optionally disable man pages (deprecated)
>> 
>> Elsewhere in JDK "deprecated" means "still works but don't use it", whereas here (and perhaps in build system overall?) it means "ignored but doesn't cause an error".
>
> Yeah, you are right. I actually had the same thought when changing this. I don't know how this came to be. Obviously, I am to blame, since I created the `UTIL_DEPRECATED_ARG_ENABLE` function. :-) What I mean is, I don't really understand why I thought "deprecated" was a good way to describe this.
> 
> I opened https://bugs.openjdk.org/browse/JDK-8343817 to deal with this systematically in the entire build system. Are you ok with keeping this in line with the rest of the build system for now?

Sure - no problem. Thanks for doing the follow up.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21936#discussion_r1835190761


More information about the build-dev mailing list