RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v10]

Magnus Ihse Bursie ihse at openjdk.org
Tue Oct 8 13:28:03 UTC 2024


On Tue, 8 Oct 2024 13:23:21 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Hamlin Li has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
>> 
>>  - merge master
>>  - bits > 512
>>  - fix test macro
>>  - check frm after sleef call
>>  - use all arg v regs
>>  - misc
>>  - refine comment
>>  - comment
>>  - modify cflags style
>>  - fix make warning
>>  - ... and 1 more: https://git.openjdk.org/jdk/compare/28977972...55434262
>
> make/modules/jdk.incubator.vector/Lib.gmk line 50:
> 
>> 48:       DISABLED_WARNINGS_clang := unused-function sign-compare tautological-compare ignored-qualifiers, \
>> 49:       CFLAGS := $(CFLAGS_JDKLIB) -march=rv64gcv, \
>> 50:       LDFLAGS := $(LDFLAGS_JDKLIB) \
> 
> Sorry for the late comment, I've been out ill. The LDFLAGS line is no longer needed and should be removed.

So is the `LIBS` line as well. And the CFLAGS line should be just:

       CFLAGS := -march=rv64gcv, \

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21083#discussion_r1791874092


More information about the build-dev mailing list