RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v10]

Hamlin Li mli at openjdk.org
Tue Oct 8 13:44:01 UTC 2024


On Tue, 8 Oct 2024 13:25:17 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> make/modules/jdk.incubator.vector/Lib.gmk line 50:
>> 
>>> 48:       DISABLED_WARNINGS_clang := unused-function sign-compare tautological-compare ignored-qualifiers, \
>>> 49:       CFLAGS := $(CFLAGS_JDKLIB) -march=rv64gcv, \
>>> 50:       LDFLAGS := $(LDFLAGS_JDKLIB) \
>> 
>> Sorry for the late comment, I've been out ill. The LDFLAGS line is no longer needed and should be removed.
>
> So is the `LIBS` line as well. And the CFLAGS line should be just:
> 
>        CFLAGS := -march=rv64gcv, \

No worries, it's not late. Take care!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21083#discussion_r1791902678


More information about the build-dev mailing list