RFR: 8341424: GHA: Collect hs_errs from build time failures [v3]

Aleksey Shipilev shade at openjdk.org
Tue Oct 8 15:02:02 UTC 2024


On Tue, 8 Oct 2024 13:08:30 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Gaaaaaaah
>
> .github/scripts/gen-build-failure-report.sh line 69:
> 
>> 67: ) >> $GITHUB_STEP_SUMMARY
>> 68: 
>> 69: # With large hs_errs, the summary can easily exceed 1024 kB, the limit set by Github
> 
> This code duplication is nagging me a bit. Do you think it would make sense to extract it to a separate helper in `.github/scripts`?

Right. Let's see if I can do this without breaking much stuff.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21308#discussion_r1792048351


More information about the build-dev mailing list