RFR: 8341424: GHA: Collect hs_errs from build time failures [v3]
Aleksey Shipilev
shade at openjdk.org
Wed Oct 9 08:13:32 UTC 2024
On Tue, 8 Oct 2024 14:59:39 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> .github/scripts/gen-build-failure-report.sh line 69:
>>
>>> 67: ) >> $GITHUB_STEP_SUMMARY
>>> 68:
>>> 69: # With large hs_errs, the summary can easily exceed 1024 kB, the limit set by Github
>>
>> This code duplication is nagging me a bit. Do you think it would make sense to extract it to a separate helper in `.github/scripts`?
>
> Right. Let's see if I can do this without breaking much stuff.
I think the separate script works!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21308#discussion_r1793069727
More information about the build-dev
mailing list